Resolve Symbols using the original fallback locale
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radar
reviewed
Jan 3, 2022
|
This change seems like it would solve the overall problem, and so I think it's worth the (potential) breakage here. The test suite for i18n is quite robust, and so I think it would do a good job of catching 99% of things that would break when new changes are introduced. For the 1%, that's inevitable and people can file new issues and we can write new tests (and patches) to address those issues if/when they arise. Could you please rebase this branch against master so that you pick up the latest GH Actions changes there? |
movermeyer
changed the title
Symbols using the original fallback localeSymbols using the original fallback locale
movermeyer
changed the title
Symbols using the original fallback localeSymbols using the original fallback locale
|
Thank you @movermeyer! |
movermeyer
added a commit
to movermeyer/rails
that referenced
this pull request
Feb 13, 2022
Adjusts to change introduced in v1.9.0 of i18n Ref: ruby-i18n/i18n#591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Proof of concept solution to #590
What approach did you choose and why?
I added a new
fallback_original_localereserved option, and make use of it in the newI18n::Backends::Fallbacks#resolvemethod.Seemed like a reasonable way to deal with it? 🤷
What should reviewers focus on?
This changes the behaviour of
resolvewhen using theFallbacksbackend, when aSymbolis resolved.This is probably a bad idea, since it is probably considered a breaking change?
I'm not sure if there is any documentation describing the "Why?" of the "resolve
Symbols" feature. It might be the case that this is exactly the desired behaviour, and therefore this is actually "just a bug fix". cc @svenfuchs, who may have more context?I mostly threw it together to start a conversation about how we might support this behaviour.
The impact of these changes
Fixes #590