Export narrow symbols from relevant currencies #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devanandersen
force-pushed
the
export-narrow-codes
branch
from
2cb5c96 to
8f92f1d
Compare
devanandersen
changed the title
devanandersen
force-pushed
the
export-narrow-codes
branch
from
8f92f1d to
513a3a2
Compare
Changes: - Export narrow currency symbols for all locales that define narrow symbols differently than regular symbols. - Add in testing (Update changelog) (Don't filter out narrow symbol if equal to regular symbol) (Naming fix)
devanandersen
force-pushed
the
export-narrow-codes
branch
from
513a3a2 to
7c84c98
Compare
Korri
approved these changes
Nov 18, 2020
|
Hello @camertron ! Hoping to get your approval on the changes here, and if you agree to merge them in too since I don't have access 😄 |
Tom-Bonnike
approved these changes
Nov 19, 2020
camertron
approved these changes
Nov 19, 2020
|
@devanandersen done! Would you like me to publish a new gem version as well? |
|
@camertron I would love that! Much appreciate if you are able 😄 |
|
@devanandersen just published v0.5.0 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some locales, the regular symbol pulled for currencies differs from the narrow symbol pulled for the same currencies.
The narrow symbols can be extracted from CLDR to better define currency symbols for the edge cases where the regular currency pulled from CLDR is not sufficient. If narrow-symbol isn't defined in the current locale, the user can check the parent locale for the narrow symbol, and so on up to root.xml
Changes: