Remove the special casing of one key
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per _Keep a Changelog_
If the locale doesn't have pluralization data for the currency: a) We shouldn't make it up b) `one` is not a valid pluralization key in most languages c) Often pluralization keys other than `one` are needed
movermeyer
force-pushed
the
mo.remove_one_special_casing
branch
from
b90e0c3 to
425adb3
Compare
Korri
approved these changes
Nov 8, 2021
cejaekl
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes #76
If the CLDR locale data doesn't have pluralization data for the currency:
a) We shouldn't make it up
b)
oneis not a valid pluralization key in most languagesc) Often pluralization keys other than
oneare neededSee #76 for the full context
What approach did you choose and why?
Simple removal of the key.
I also had to fix the
CHANGELOGto be able to include a note on this change. It was sorted backwards from what Keep a Changelog specifies, and it was missing an entry for my previous change.What should reviewers focus on?
🤷 I've documented the change, and
ruby-cldris pre-1.0.0, so "Anything MAY change at any time".The impact of these changes
Consumers may have to update their code if they were relying on this key's existence.
ruby-cldrwill no longer be making up data in this case. 👍Testing
thor cldr:export --components currenciesdata/af/currencies.ymlNote that there is no longer any
onekey forLVL, since there is noonekey forLVLin the CLDR data.