Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the connection class (by default
Net::LDAP::Connection
) and the socket class (by defaultTCPSocket
) configurable, and extracts the repetitive "new connection" stanza into anew_connection
method.I don't foresee people replacing either object with something entirely different, but this opens up new opportunities for integrators to wrap the
Net::LDAP::Connection
or theTCPSocket
classes with a decorator or anything without having to monkeypatch the class.Need to document, test the behavior, but wanted to open up the idea for discussion first.
cc @jch @schaary