Add tests for SPARQL results parsing. #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- save blank nodes in nodes table. - Don't crash when columns are empty.
gkellogg
added a commit
that referenced
this pull request
Dec 19, 2013
|
Please check out the develop branch to make sure it's working properly for you. |
|
That's great, thanks. It works fine for me. There's a branch here that runs the tests in travis both with and without nokogiri. Results here: It's probably not necesary for regular tests, but i wanted to prove to myself that it's correct. |
|
Thanks Tom, that's useful; I'll merge that in. |
|
Thanks; i'd be happy to send a pull request if that's easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add tests for the
parse_x_bindingsfunctions, and fix a few minor issues found along the way:It was a bit tricky to wedge these into rspec; I'm open to suggestions. If nothing else this can be used to check the correctness of #36.
Thanks!