Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer required refinements #250

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Remove no longer required refinements #250

merged 1 commit into from
Jun 18, 2022

Conversation

Maumagnaguagno
Copy link
Contributor

Since PR #159, the minimum Ruby version is 2.5.0, a version which no longer requires refinements for String#delete_suffix?, String#match? and Regexp#match?.

Since PR #159, the minimum Ruby version is 2.5.0, a version which no
longer requires refinements for String#delete_suffix?, String#match? and
Regexp#match?.
@kou kou merged commit b39e930 into ruby:master Jun 18, 2022
@kou
Copy link
Member

kou commented Jun 18, 2022

Good catch!

@Maumagnaguagno Maumagnaguagno deleted the old-refinements branch June 20, 2022 18:07
peterzhu2118 pushed a commit to Shopify/ruby that referenced this pull request Dec 6, 2022
(ruby/csv#250)

Since PR #159, the minimum Ruby version is 2.5.0, a version which no
longer requires refinements for String#delete_suffix?, String#match? and
Regexp#match?.
nobu pushed a commit to nobu/ruby that referenced this pull request May 24, 2023
(ruby/csv#250)

Since PR ruby#159, the minimum Ruby version is 2.5.0, a version which no
longer requires refinements for String#delete_suffix?, String#match? and
Regexp#match?.
nobu pushed a commit to ruby/ruby that referenced this pull request May 24, 2023
(ruby/csv#250)

Since PR #159, the minimum Ruby version is 2.5.0, a version which no
longer requires refinements for String#delete_suffix?, String#match? and
Regexp#match?.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants