Readable prefix/suffix removal in Parser#strip_value #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of String#delete_prefix!/delete_suffix! makes this method more readable.
kou
reviewed
Jun 24, 2022
|
Thanks! |
peterzhu2118
pushed a commit
to Shopify/ruby
that referenced
this pull request
Dec 6, 2022
(ruby/csv#251) The use of String#delete_prefix!/delete_suffix! makes this method more readable. ruby/csv@698d1fad55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
String#delete_prefix!/delete_suffix!makes this method more readable.It also makes possible to strip strings with more than one character.
Note that I am using the methods ending with
!to modifyvalue, this matches the already usedstrip!.I also modified the early return to show that
valueis always returned, and with this PR allvaluemodifications happen in-place.This could be used to further simplify the method itself (no need to return a value) and the single usage I have found in
Parser#parse_no_quote:line = strip_value(line)tostrip_value(line).I have not done this modification yet to leave it open for discussion.