Remove key sorting in CSV.instance #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``DEFAULT_OPTIONS`` is a frozen Hash with symbols as keys. There is no need to convert such keys to strings before sorting. Note that sorting is not needed for stable implementations of Hash, keys would always be returned in the same entry order. We could remove sorting if every supported Ruby implements entry order Hashes.
kou
reviewed
Nov 11, 2022
Only required by old Rubies. Co-authored-by: Sutou Kouhei <[email protected]>
Maumagnaguagno
changed the title
peterzhu2118
pushed a commit
to Shopify/ruby
that referenced
this pull request
Dec 6, 2022
(ruby/csv#262) ``DEFAULT_OPTIONS`` is a frozen Hash with symbols as keys. There is no need to convert such keys to strings before sorting. Note that sorting is not needed for stable implementations of Hash, keys would always be returned in the same entry order. Sorting removed as all supported Ruby versions implement entry order Hashes. Co-authored-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFAULT_OPTIONSis a frozen Hash with symbols as keys.There is no need to convert such keys to strings before sorting.
Note that sorting is not needed for stable implementations of Hash, keys would always be returned in the same entry order.
Sorting removed as all supported Ruby versions implement entry order Hashes.