-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish the exit! command and its tests #867
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
247d419
Remove IRB.irb_exit! method
st0012 2f3705d
Rename ExitForcedAction to ForceExit
st0012 77c4391
Move force exit tests to a dedicated file
st0012 22842b7
Fix nested history saving with exit! command
st0012 441c9fb
execute_lines helper should also capture IRB setup's output
st0012 7ed98c8
Update readme
st0012 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# frozen_string_literal: false | ||
require 'irb' | ||
|
||
require_relative "../helper" | ||
|
||
module TestIRB | ||
class ForceExitTest < IntegrationTestCase | ||
def test_forced_exit_finishes_process_immediately | ||
write_ruby <<~'ruby' | ||
puts "First line" | ||
puts "Second line" | ||
binding.irb | ||
puts "Third line" | ||
binding.irb | ||
puts "Fourth line" | ||
ruby | ||
|
||
output = run_ruby_file do | ||
type "123" | ||
type "456" | ||
type "exit!" | ||
end | ||
|
||
assert_match(/First line\r\n/, output) | ||
assert_match(/Second line\r\n/, output) | ||
assert_match(/irb\(main\):001> 123/, output) | ||
assert_match(/irb\(main\):002> 456/, output) | ||
refute_match(/Third line\r\n/, output) | ||
refute_match(/Fourth line\r\n/, output) | ||
end | ||
|
||
def test_forced_exit_in_nested_sessions | ||
write_ruby <<~'ruby' | ||
def foo | ||
binding.irb | ||
end | ||
|
||
binding.irb | ||
binding.irb | ||
ruby | ||
|
||
output = run_ruby_file do | ||
type "123" | ||
type "foo" | ||
type "exit!" | ||
end | ||
|
||
assert_match(/irb\(main\):001> 123/, output) | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend
exit
orexit(true)
instead ofexit(0)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Address it in #868