Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.3.0 does not support Ruby 1.9 but the gemspec says it does #395

Closed
mvz opened this issue Dec 21, 2019 · 2 comments · Fixed by #396
Closed

Version 2.3.0 does not support Ruby 1.9 but the gemspec says it does #395

mvz opened this issue Dec 21, 2019 · 2 comments · Fixed by #396

Comments

@mvz
Copy link

mvz commented Dec 21, 2019

On 1.9.3 I get this error:

SyntaxError:
  /home/travis/build/cucumber/aruba/vendor/bundle/ruby/1.9.1/gems/json-2.3.0/lib/json/common.rb:156: syntax error, unexpected tPOW, expecting ')'
      Parser.new(source, **(opts||{})).parse
                           ^

[...]

However, the 2.3.0 gemspec says:

s.required_ruby_version = Gem::Requirement.new(">= 1.9".freeze)
@hsbt hsbt mentioned this issue Dec 22, 2019
Merged
@hsbt hsbt closed this as completed in #396 Dec 23, 2019
@hsbt
Copy link
Member

hsbt commented Dec 23, 2019

@mvz Thanks, I did update the gemspec.

@mvz
Copy link
Author

mvz commented Dec 23, 2019

Thanks, @hsbt.

@wynksaiddestroy wynksaiddestroy mentioned this issue Mar 14, 2020
Merged
sshao added a commit to sshao/business_calendar that referenced this issue May 27, 2020
@sshao
Update .travis.yml
e6eca26 
- need to lock json for ruby-1.9 due to
ruby/json#395
sshao added a commit to sshao/business_calendar that referenced this issue May 27, 2020
@sshao
Update .travis.yml
00fe701 
- need to lock json for ruby-1.9 due to
ruby/json#395
sshao added a commit to sshao/business_calendar that referenced this issue May 27, 2020
@sshao
Update .travis.yml
1a0f1d4 
- and remove bundler development dependency
- need to lock json for ruby-1.9 due to
ruby/json#395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

keyword argument is provided after Ruby 2.0+ ruby/json
2 participants
@mvz @hsbt