Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-ftp-0.3.6 is failed with ruby/spec #36

Closed
hsbt opened this issue Jun 6, 2024 · 0 comments · Fixed by ruby/ruby#11012
Closed

net-ftp-0.3.6 is failed with ruby/spec #36

hsbt opened this issue Jun 6, 2024 · 0 comments · Fixed by ruby/ruby#11012

Comments

@hsbt
Copy link
Member

hsbt commented Jun 6, 2024

I try to update bundled version of ruby/ruby to net-ftp-0.3.6. But this version failed with ruby/spec now.

1)
Net::FTP#put (text mode) returns nil FAILED
Expected "200 OK, Data received. (STOR text)\n" to be nil
/Users/hsbt/Documents/github.com/ruby/ruby/spec/ruby/library/net-ftp/shared/puttextfile.rb:38:in 'block (2 levels) in <top (required)>'
/Users/hsbt/Documents/github.com/ruby/ruby/spec/ruby/library/net-ftp/put_spec.rb:15:in '<top (required)>'

2)
Net::FTP#puttextfile returns nil FAILED
Expected "200 OK, Data received. (STOR text)\n" to be nil
/Users/hsbt/Documents/github.com/ruby/ruby/spec/ruby/library/net-ftp/shared/puttextfile.rb:38:in 'block (2 levels) in <top (required)>'
/Users/hsbt/Documents/github.com/ruby/ruby/spec/ruby/library/net-ftp/puttextfile_spec.rb:6:in '<top (required)>'
hsbt added a commit to hsbt/ruby that referenced this issue Jun 18, 2024
@hsbt
net-ftp-0.3.6 always return response with put/puttextfile.
fec5078 
* ruby/net-ftp#34
* ruby/net-ftp#36
@hsbt hsbt mentioned this issue Jun 18, 2024
Merged
hsbt added a commit to ruby/ruby that referenced this issue Jun 18, 2024
@hsbt
net-ftp-0.3.6 always return response with put/puttextfile.
dd704eb 
* ruby/net-ftp#34
* ruby/net-ftp#36
andrykonchin pushed a commit to ruby/spec that referenced this issue Jul 1, 2024
@hsbt @andrykonchin
net-ftp-0.3.6 always return response with put/puttextfile.
c4e1a6b 
* ruby/net-ftp#34
* ruby/net-ftp#36
headius pushed a commit to headius/spec that referenced this issue Oct 31, 2024
@hsbt
net-ftp-0.3.6 always return response with put/puttextfile.
9aae479 
* ruby/net-ftp#34
* ruby/net-ftp#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump up net-ftp 0.3.6 hsbt/ruby
1 participant
@hsbt