Use assert_raises instead of assert_raise for SocketError
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following PR changes cause Socket::ResolutionError, a subclass of SocketError, to be raised in this test case. ruby/ruby#9018 While `assert_raise` verifies that the error being raised is indeed a SocketError, `assert_raises` can verify that it is a SocketError or a subclass thereof. It will avoid unwanted test failures.
|
|
|
Thank you to your feedback. Now I opened a new PR #23 for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR changes cause
Socket::ResolutionError, a subclass ofSocketError, to be raised in this test case. ruby/ruby#9018While
assert_raiseverifies that the error being raised is indeed aSocketError,assert_raisescan verify that it is a SocketError or a subclass thereof. It will avoid unwanted test failures.