Enable frozen_string_literal #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Net::HTTP contain quite a few string literals that would benefit from being interned.
jeremyevans
reviewed
Aug 20, 2022
There was a problem hiding this comment.
The implementation looks fine to me, but this change probably needs to be approved by @nurse.
|
Have we taken a look at merging this one? Probably needs to be rebased though. |
|
@baweaver and I were pairing on some performance issues last month with memory_profiler, and stumbled upon net/http in a few spots For our one system spec, we're seeing |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::HTTP contain quite a few string literals that would benefit from being interned.