🐛 Fix SequenceSet#append
when its @string
is nil
#376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a SequenceSet is not normalized, it stores its string in
@string
. When it is normalized,@string
is still used as a cache for@string
.When
@string
isn't set, but the sequence set is not empty,#append
would generate the normalized string after adding the new numbers, and then append the new numbers to the end of the string. For example:This PR forces the string to be generated prior to adding the new numbers, so they can be appended to the end.