Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ENV.update #40

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Use ENV.update #40

merged 1 commit into from
Nov 25, 2024

Conversation

nobu
Copy link
Member

@nobu nobu commented Oct 2, 2024

No description provided.

@olleolleolle
Copy link
Contributor

👋 I had to re-read the title of the PR, and then I saw that unlike in the title, in the code we use the ENV.update method, which makes the same thing as before. https://rubyapi.org/3.3/o/env#method-c-update

@nobu nobu changed the title Use ENV.replace Use ENV.update Nov 25, 2024
@nobu
Copy link
Member Author

nobu commented Nov 25, 2024

Sorry, the title was a mistake.

@hsbt
Copy link
Member

hsbt commented Nov 25, 2024

@nobu Can you also update commit message?

@hsbt hsbt merged commit 81c0b34 into ruby:master Nov 25, 2024
24 checks passed
@nobu nobu deleted the with_env branch November 25, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants