Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust crate publishing (dry-run) #2009

Closed
wants to merge 2 commits into from
Closed

Rust crate publishing (dry-run) #2009

wants to merge 2 commits into from

Conversation

ngroman
Copy link
Contributor

@ngroman ngroman commented Dec 7, 2023

I think this is a possible fix for #1786

This change consolidates the prism and prism-sys crates into a single workspace that shares one Cargo.lock.

The somewhat unfortunate part here is that for prism-sys I have to use --allow-dirty with cargo publish because the C files and headers that are copied over by rake cargo:build must also be published.

Testing

Ran git clean -xfd && RBENV_VERSION=3.1 bundle exec rake cargo:publish:dry

Note this still fails with error because prism-sys does not exist on crates.io

@kddnewton
Copy link
Collaborator

Sorry I didn't manage to get to this this week, I'll work on it next week. At first glance it looks good.

@kddnewton
Copy link
Collaborator

@ngroman going to try to publish this today/tomorrow.

@kddnewton kddnewton mentioned this pull request Dec 15, 2023
@kddnewton
Copy link
Collaborator

This is now merged!

@kddnewton kddnewton closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants