Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape newline #2033

Merged
merged 1 commit into from
Dec 10, 2023
Merged

fix: escape newline #2033

merged 1 commit into from
Dec 10, 2023

Conversation

k0va1
Copy link
Contributor

@k0va1 k0va1 commented Dec 9, 2023

If you try to print error message using printf it'll add newline. So I think that would be better to escape `\n'

@k0va1 k0va1 force-pushed the bugfix/escape_newline branch from 2f9596e to a28b427 Compare December 9, 2023 16:31
kddnewton
kddnewton approved these changes Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@kddnewton kddnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kddnewton kddnewton merged commit 749b1f4 into ruby:main Dec 10, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0va1 @kddnewton