Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eval parsing depth #2093

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix eval parsing depth #2093

merged 1 commit into from
Dec 15, 2023

Conversation

kddnewton
Copy link
Collaborator

Previously we would always push a new scope, which was inaccurate because eval can introduce locals in the caller's scope.

@kddnewton kddnewton merged commit 41596b6 into main Dec 15, 2023
46 checks passed
@kddnewton kddnewton deleted the fix-eval-depth branch December 15, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kddnewton