Fix to check multiple block arguments for forwarding arg #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,6 +56,7 @@ static const char* const diagnostic_messages[PM_DIAGNOSTIC_ID_LEN] = { | |||
| [PM_ERR_ARGUMENT_AFTER_BLOCK] = "unexpected argument after a block argument", | |||
| [PM_ERR_ARGUMENT_AFTER_FORWARDING_ELLIPSES] = "unexpected argument after `...`", | |||
| [PM_ERR_ARGUMENT_BARE_HASH] = "unexpected bare hash argument", | |||
| [PM_ERR_ARGUMENT_BLOCK_FORWARDING] = "both a block argument and a forwarding argument; only one block is allowed", | |||
| [PM_ERR_ARGUMENT_BLOCK_MULTI] = "multiple block arguments; only one block is allowed", | |||
There was a problem hiding this comment.
Does it make sense to use PM_ERR_ARGUMENT_BLOCK_MULTI message instead?
In all the other cases with two block arguments Prism returns multiple block arguments; only one block is allowed error:
def bar(&)
foo(&) { }
end
def bar()
foo(&:to_s) { }
endThere was a problem hiding this comment.
It makes sense of course. However, I believe the detailed error message helps users, so I introduce the new error message for this.
kddnewton
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2111