Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional fallback return value parameter #264

Merged
merged 1 commit into from
Jun 24, 2016
Merged

Add optional fallback return value parameter #264

merged 1 commit into from
Jun 24, 2016

Conversation

tuexss
Copy link
Contributor

@tuexss tuexss commented Jan 8, 2016

As suggested in #149

@tenderlove
Copy link
Member

LGTM. You mentioned in #149 that we should be returning nil by default. I think we should, but I'm unsure if I could change this return value in a bugfix release. I guess nil is still falsey, and the behavior isn't documented, so I'm not sure.

@tuexss
Copy link
Contributor Author

tuexss commented Jan 8, 2016

Yes, I agree. Adding a feature is one thing, changing current behavior a different one. Maybe it should fail with a proper exception.

Do you have any idea what I can do about appveyor failing?

@sandstrom
Copy link

I just hit this. Getting nil in return is what I'd expect, and since both false and nil are falsy I wouldn't be to worried about changing in a bugfix release.

@tenderlove tenderlove merged commit c364faf into ruby:master Jun 24, 2016
@tuexss tuexss deleted the load_file-default branch June 24, 2016 09:44
@sandstrom
Copy link

Nice! ⛵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants