Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only skip specific failures on JRuby instead of ignoring the whole CI feedback #524

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Oct 12, 2021

@deivid-rodriguez deivid-rodriguez marked this pull request as draft October 12, 2021 16:00
@deivid-rodriguez
Copy link
Contributor Author

This PR is just to proof that the changes work, but it should not be merged. Once jruby/ruby-maven#2 is merged and released, things should start working without any changes.

@deivid-rodriguez
Copy link
Contributor Author

Alright so dependent PRs are moving forward, and this is now only missing a ruby-maven release.

However, the gem became uninstallable again on jruby after #525, since gemified stringio does not yet support jruby (WIP for that is ruby/stringio#21).

@headius
Copy link
Contributor

headius commented Sep 19, 2022

This would be worth revisiting with latest SnakeYAML. On master, I now see 5F7E. Some of these may be valid differences (SnakeYAML appears to report line/column positioning a bit differently) but several appear to be fixable errors or bugs. We also addressed the stringio gemification for JRuby 9.4.

@deivid-rodriguez
Copy link
Contributor Author

@headius I completely lost context of this PR. I think the original issues I wanted to address are now fixed, but a few others remain. I changed the scope of this PR to:

  • Use Bundler to install dependencies and run tests.
  • Only skip the particular tests that are failing instead of ignoring the whole test run outcome. I think this should help preventing new regressions.

Let's see what CI says.

@deivid-rodriguez deivid-rodriguez changed the title Experiments to fix JRuby CI Only skip specific failures on JRuby instead of ignoring the whole CI feeback Sep 27, 2022
@deivid-rodriguez deivid-rodriguez changed the title Only skip specific failures on JRuby instead of ignoring the whole CI feeback Only skip specific failures on JRuby instead of ignoring the whole CI feedback Sep 27, 2022
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review September 27, 2022 12:14
@deivid-rodriguez
Copy link
Contributor Author

Except for the specs that are marked as pending, everything is now green on JRuby, so I set this as ready for review.

@headius
Copy link
Contributor

headius commented Sep 27, 2022

@deivid-rodriguez Very nice! Good idea to skip some tests that are problematic... some might not be fixable due to minor differences in SnakeYAML (positioning information etc).

@tenderlove Any objections to merging this PR? It marks a number of tests as pending, but I'm not sure they are fixable and it would be good to have a green-ish run so we can see when things regress.

This way we should be able to prevent new regressions from being
introduced.
@hsbt
Copy link
Member

hsbt commented Oct 7, 2022

@deivid-rodriguez 👍 Thanks!

@hsbt hsbt merged commit ed5ce03 into ruby:master Oct 7, 2022
@deivid-rodriguez deivid-rodriguez deleted the fix_jruby_ci branch October 7, 2022 10:03
@hsbt hsbt mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants