Guard from memory leak in Psych::Emitter#start_document #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception is raised, it can leak memory in
head
. There are two places that can leak memory:Check_Type(tuple, T_ARRAY)
can leak memory iftuple
is not an array.StringValue(name)
andStringValue(value)
if they are not strings and the call toto_str
does not return a string.This commit fixes these memory leaks by wrapping the code around a rb_ensure so that the memory is freed in all cases.
The following code demonstrates the memory leak:
Before:
After: