Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #137] Improve reporting #138

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Conversation

marcandre
Copy link
Member

@marcandre marcandre commented Aug 14, 2020

Before:

1 useless nonterminals
2 useless rules
1 shift/reduce conflicts

After:

1 useless nonterminals:
  dummy
2 useless rules:
  #4 (dummy)
  #5 (dummy)
1 shift/reduce conflicts
Turn on logging with "-v" and check ".output" file for details

Detailed list are limited to 10

@marcandre marcandre requested a review from zenspider August 14, 2020 02:16
@duerst
Copy link
Member

duerst commented Aug 14, 2020

Very minor comment: If the .output file is similar to the one bison produces, then I wouldn't call this a log file.

@marcandre
Copy link
Member Author

Very minor comment: If the .output file is similar to the one bison produces, then I wouldn't call this a log file.

I agree it's not what I would expect of a "log file", but it is the way it is called in the "help" and in the code. Nevertheless I removed the word "log" from the new output.

@zenspider
Copy link
Member

Failing on jruby-9.2 (but not head?!?)... I don't know from the output what is wrong and what is noise.

@zenspider
Copy link
Member

zenspider commented Aug 17, 2020

@marcandre looks like:

2020-08-14T03:45:09.8966400Z Failure: test_ifelse(Racc::TestRaccCommand)
2020-08-14T03:45:09.9105454Z /home/runner/work/racc/racc/test/test_racc_command.rb:325:in `test_ifelse'
2020-08-14T03:45:09.9111513Z      322:     def test_ifelse
2020-08-14T03:45:09.9111899Z      323:       stderr = nil
2020-08-14T03:45:09.9112659Z      324:       racc "-o#{@TAB_DIR}/ifelse", "#{ASSET_DIR}/ifelse.y", stdout_filter: ->(s) { stderr = s }
2020-08-14T03:45:09.9112978Z   => 325:       assert_equal(<<~STDERR, stderr)
2020-08-14T03:45:09.9113213Z      326:         1 useless nonterminals:
2020-08-14T03:45:09.9113454Z      327:           dummy
2020-08-14T03:45:09.9134532Z      328:         2 useless rules:

it just goes for miles... nasty

@marcandre
Copy link
Member Author

Rebased to include #139, should be green now...

@marcandre marcandre merged commit 5897461 into ruby:master Aug 19, 2020
@marcandre marcandre deleted the less_useless branch August 26, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants