Merge pull request #906 from pocke/Do_not_call__class_from__hash

Do not call #class from #hash to imorove performance
ruby · Feb 21, 2022 · 4afd14d · 4afd14d
2 parents 026d73d + 5b1251c
commit 4afd14d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/lib/rbs/ast/members.rb b/lib/rbs/ast/members.rb
@@ -34,7 +34,7 @@ def ==(other)
         alias eql? ==
 
         def hash
-          self.class.hash ^ name.hash ^ kind.hash ^ types.hash ^ overload.hash
+          name.hash ^ kind.hash ^ types.hash ^ overload.hash
         end
 
         def instance?
@@ -94,7 +94,7 @@ def ==(other)
         alias eql? ==
 
         def hash
-          self.class.hash ^ name.hash ^ type.hash
+          name.hash ^ type.hash
         end
       end
 
@@ -164,7 +164,7 @@ def eql?(other)
         end
 
         def hash
-          self.class.hash ^ name.hash ^ args.hash
+          name.hash ^ args.hash
         end
       end
 
@@ -243,7 +243,7 @@ def ==(other)
         alias eql? ==
 
         def hash
-          self.class.hash ^ name.hash ^ type.hash ^ ivar_name.hash ^ kind.hash
+          name.hash ^ type.hash ^ ivar_name.hash ^ kind.hash
         end
 
         def update(name: self.name, type: self.type, ivar_name: self.ivar_name, kind: self.kind, annotations: self.annotations, location: self.location, comment: self.comment)
@@ -372,7 +372,7 @@ def ==(other)
         alias eql? ==
 
         def hash
-          self.class.hash ^ new_name.hash ^ old_name.hash ^ kind.hash
+          new_name.hash ^ old_name.hash ^ kind.hash
         end
 
         def to_json(state = _ = nil)

diff --git a/lib/rbs/namespace.rb b/lib/rbs/namespace.rb
@@ -59,7 +59,7 @@ def ==(other)
     alias eql? ==
 
     def hash
-      self.class.hash ^ path.hash ^ absolute?.hash
+      path.hash ^ absolute?.hash
     end
 
     def split

diff --git a/lib/rbs/type_name.rb b/lib/rbs/type_name.rb
@@ -27,7 +27,7 @@ def ==(other)
     alias eql? ==
 
     def hash
-      self.class.hash ^ namespace.hash ^ name.hash
+      namespace.hash ^ name.hash
     end
 
     def to_s

diff --git a/lib/rbs/types.rb b/lib/rbs/types.rb
@@ -213,7 +213,7 @@ def ==(other)
       alias eql? ==
 
       def hash
-        self.class.hash ^ name.hash ^ args.hash
+        name.hash ^ args.hash
       end
 
       def free_variables(set = Set.new)