Fix 3.4 prototype rb failure

ruby · Jan 9, 2024 · d760480 · d760480
1 parent c7e53d2
commit d760480
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/rbs/prototype/rb.rb b/lib/rbs/prototype/rb.rb
@@ -603,6 +603,11 @@ def literal_to_type(node)
             end
           when Integer
             Types::Literal.new(literal: lit, location: nil)
+          when String
+            # For Ruby >=3.3 which generates `LIT` node for string literals inside Hash literal.
+            # "a"             => STR node
+            # { "a" => nil }  => LIT node
+            Types::Literal.new(literal: lit, location: nil)
           else
             type_name = TypeName.new(name: lit.class.name.to_sym, namespace: Namespace.root)
             Types::ClassInstance.new(name: type_name, args: [], location: nil)

diff --git a/test/rbs/rb_prototype_test.rb b/test/rbs/rb_prototype_test.rb
@@ -1033,7 +1033,7 @@ def test_literal_to_type
       [%{1..2}, %{::Range[::Integer]}],
       [%{{}}, %{::Hash[untyped, untyped]}],
       [%{{a: nil}}, %{ { a: nil } }],
-      [%{{"a" => /b/}}, %{ ::Hash[::String, ::Regexp] }],
+      [%({"a" => /b/}), %({ 'a' => ::Regexp })],
     ].each do |rb, rbs|
       node = RubyVM::AbstractSyntaxTree.parse("_ = #{rb}").children[2]
       assert_equal RBS::Parser.parse_type(rbs), parser.literal_to_type(node.children[1])