Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSSL::PKey::PKeyError: EVP_PKEY_keygen: bad ffc parameters with OpenSSL 3 #1005

Merged
merged 1 commit into from
May 23, 2022

Conversation

znz
Copy link
Member

@znz znz commented May 23, 2022

For example:

  Error: test_export(OpenSSLDSATest): OpenSSL::PKey::PKeyError: EVP_PKEY_keygen: bad ffc parameters
  /home/runner/work/actions/actions/snapshot-master/.ext/common/openssl/pkey.rb:173:in `generate_key'
  /home/runner/work/actions/actions/snapshot-master/.ext/common/openssl/pkey.rb:173:in `generate'
  /home/runner/work/actions/actions/snapshot-master/.ext/common/openssl/pkey.rb:180:in `new'
  test/stdlib/OpenSSL_test.rb:776:in `pkey'
  test/stdlib/OpenSSL_test.rb:717:in `test_export'

Before:
113 tests, 362 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications
After:
113 tests, 386 assertions, 0 failures, 10 errors, 0 pendings, 0 omissions, 0 notifications

…ith OpenSSL 3

For example:
```
  Error: test_export(OpenSSLDSATest): OpenSSL::PKey::PKeyError: EVP_PKEY_keygen: bad ffc parameters
  /home/runner/work/actions/actions/snapshot-master/.ext/common/openssl/pkey.rb:173:in `generate_key'
  /home/runner/work/actions/actions/snapshot-master/.ext/common/openssl/pkey.rb:173:in `generate'
  /home/runner/work/actions/actions/snapshot-master/.ext/common/openssl/pkey.rb:180:in `new'
  test/stdlib/OpenSSL_test.rb:776:in `pkey'
  test/stdlib/OpenSSL_test.rb:717:in `test_export'
```
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🙇‍♂️

@soutaro soutaro merged commit fa285f0 into ruby:master May 23, 2022
@znz znz deleted the fix-bad-ffc-parameters branch May 25, 2022 13:23
soutaro added a commit that referenced this pull request Jun 19, 2022
Fix `OpenSSL::PKey::PKeyError: EVP_PKEY_keygen: bad ffc parameters` with OpenSSL 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants