Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rational#* signature #1012

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Fix Rational#* signature #1012

merged 3 commits into from
Jun 20, 2022

Conversation

kachick
Copy link
Member

@kachick kachick commented Jun 1, 2022 •
edited
Loading

Currently trancated to Numeric

(Rational(4, 3) * 2).to_i
#=> Type `::Numeric` does not have method `to_i`(Ruby::NoMethod)

Smilar issues looks exists in around calculation methods. However this PR scopes only to multiply for now.

kachick
kachick commented Jun 1, 2022
View reviewed changes
core/rational.rbs Outdated Show resolved Hide resolved
@kachick kachick mentioned this pull request Jun 1, 2022
Merged
soutaro
soutaro approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙏

@soutaro soutaro merged commit b2cad47 into ruby:master Jun 20, 2022
@kachick
Copy link
Member Author

kachick commented Jun 20, 2022

Thank you!

@kachick kachick deleted the fix-sig-rational-mul branch June 20, 2022 04:48
@kachick kachick mentioned this pull request Jun 22, 2022
Merged
kachick added a commit to kachick/ruby-ulid that referenced this pull request Jun 22, 2022
@kachick
Remove comment since releasing ruby/rbs#1012
1fe2c7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kachick @soutaro