Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay loading Gemfile for unbundled environments #1161

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Delay loading Gemfile for unbundled environments #1161

merged 4 commits into from
Nov 28, 2022

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Nov 26, 2022 •
edited
Loading

rbs collection * raised Bundler::GemfileNotFound error if Gemfile cannot be located, even for install --frozen that doesn't access Bundler at all. This PR delays loading Gemfile and lets install --frozen run without Bundler.

Also fixes collection tests to set up another Bundler context.

@soutaro soutaro marked this pull request as ready for review November 26, 2022 06:48
@soutaro soutaro changed the title Fix collection tests Delay loading Gemfile for non-bundler environments Nov 28, 2022
@soutaro soutaro changed the title Delay loading Gemfile for non-bundler environments Delay loading Gemfile for unbundled environments Nov 28, 2022
@soutaro soutaro merged commit 9a1f2f0 into master Nov 28, 2022
@soutaro soutaro deleted the revise-collection branch November 28, 2022 00:42
@soutaro soutaro added this to the RBS 2.8.x milestone Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
RBS 2.8.x
Development

Successfully merging this pull request may close these issues.
1 participant
@soutaro