Fix super class of NoTypeFoundError from BaseError to DefinitionError #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
Fix_super_class_of_NoTypeFoundError_from_BaseError_to_DefinitionError
branch
from
6133fbb to
a6e20fe
Compare
soutaro
approved these changes
Apr 14, 2023
pocke
deleted the
Fix_super_class_of_NoTypeFoundError_from_BaseError_to_DefinitionError
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoTypeFoundError inherits different classes between Ruby and RBS.
It inherits BaseError on the Ruby level but inherits DefinitionError on the RBS level.
This PR fixes the Ruby-level superclass. This error occurs during building definitions, so DefinitionError is the correct superclass.