Fix InvalidOverloadMethodError on overloading extended method #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
Fix_InvalidOverloadMethodError_on_overloading_extended_method
branch
from
76f3e59 to
ccdcb47
Compare
pocke
deleted the
Fix_InvalidOverloadMethodError_on_overloading_extended_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1293
This PR fixes InvalidOverloadMethodError when a class has an overloading singleton method for an extended method.
#1268 introduced this problem. It added an
import_methodscall before defining methods of extended modules, butimport_methodsdepends on it. So theimport_methodscannot find methods defined by extended modules.This PR moves
import_methodsafterdefine_instancefor extended modules, and removes duplicatedimport_methodsbecause it was called twice since #1294.