Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate gem specific sources in lockfile #1402

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Jul 30, 2023

The gem specific sources are ignored when:

  • The gem X is a dependency of another gem Y that is also listed in gems section prior to the gem

For example:

gems:
  - name: X
  - name: Y
    source:
      type: git
      ...
  1. X is added to the lockfile before Y
  2. The source definition of Y is ignored because it's traversed as a dependency of X
  3. Y is skipped from the gems section, because it's already added to the lockfile (without custom source section)

This PR fixes the problem by introducing gem_entries hash and referees the ignore and source attribute through it instead of passing it as method arguments.

@soutaro soutaro added this to the RBS 3.2 milestone Jul 30, 2023
@soutaro soutaro added this pull request to the merge queue Jul 31, 2023
Merged via the queue into master with commit 4642668 Jul 31, 2023
@soutaro soutaro deleted the fix-lockfile-generator branch July 31, 2023 01:35
soutaro added a commit that referenced this pull request Jul 31, 2023
Generate gem specific sources in lockfile
soutaro added a commit that referenced this pull request Jul 31, 2023
Generate gem specific sources in lockfile
soutaro added a commit that referenced this pull request Jul 31, 2023
Backport #1402 (fix-lockfile-generator)
@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

1 participant