Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Warning #1477

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Cleanup Warning #1477

merged 1 commit into from
Aug 29, 2023

Conversation

sampersand
Copy link
Contributor

This adds mainly adds support for Warning[:deprecated] and Warning[:deprecated] = foo, but also:

  • Adds the ToSym test helper type
  • Added documentation for Warning::category
  • Abstracted out the list of catagories within the unit tests (in preparation for when performance is added in the future.)

@sampersand sampersand marked this pull request as ready for review August 29, 2023 00:25
@sampersand sampersand force-pushed the swesterman/23-08-28/update-warning branch from 15c8485 to 54315f1 Compare August 29, 2023 01:34
@sampersand sampersand force-pushed the swesterman/23-08-28/update-warning branch from 54315f1 to 2e9e655 Compare August 29, 2023 01:37
soutaro
soutaro approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@soutaro soutaro added this to the RBS 3.3 milestone Aug 29, 2023
@soutaro soutaro added this pull request to the merge queue Aug 29, 2023
Merged via the queue into ruby:master with commit 44fad0b Aug 29, 2023
@soutaro soutaro added the Released PRs already included in the released version label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sampersand @soutaro