Update FileTest's definitions #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampersand
changed the title
sampersand
force-pushed
the
swesterman/23-09-04/update-filetest
branch
2 times, most recently
from
edf7262 to
0ce2fb2
Compare
sampersand
force-pushed
the
swesterman/23-09-04/update-filetest
branch
from
0ce2fb2 to
741b1a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the signatures for
FileTest, and updates the unit tests accordingly.The current signatures are actually pretty accurate, they are just missing the implicit conversions.
More concretely the following changes were made to
FileTest's signatures:blockdev?,chardev?,directory?,exist?,file?,grpowned?,owned?,pipe?,setgid?,setuid?,size?,size?,socket?,sticky?,world_readable?,world_writable?, andzero?: Converted from(String | IO) -> ...to(path | io) -> ....empty?: Changed to be an alias ofzero?.executable?,executable_real?,readable?,readable_real?,symlink?,writable?, andwritable_real?: Converted from(String) -> ...to(path) -> ....identical?: Changed from(String | IO, String | IO) -> ...to(path | io, path | io) -> ....