Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make alias and interface names absolute #1502

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Make alias and interface names absolute #1502

merged 1 commit into from
Sep 5, 2023

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Sep 5, 2023

RBS test currently causes Unknown alias name: interned when relative type alias name or interface name is given through assert_send_type and the family.

This patch calls #absolute so that relative names will be converted to the absolute name. No type name resolution happens. It just adds :: at the head of the type name.

@soutaro soutaro added this to the RBS 3.3 milestone Sep 5, 2023
@soutaro soutaro mentioned this pull request Sep 5, 2023
Merged
@soutaro soutaro enabled auto-merge September 5, 2023 07:09
@soutaro soutaro added this pull request to the merge queue Sep 5, 2023
Merged via the queue into master with commit fce99b9 Sep 5, 2023
@soutaro soutaro deleted the relative-type-names branch September 5, 2023 07:18
ParadoxV5 added a commit to ParadoxV5/rbs that referenced this pull request Sep 5, 2023
@ParadoxV5
Merge branch 'master' into interned
3cdd913 
ruby#1502
@soutaro soutaro added the Released PRs already included in the released version label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.3
Development

Successfully merging this pull request may close these issues.
1 participant
@soutaro