Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BasicObject #1506

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

sampersand
Copy link
Contributor

@sampersand sampersand commented Sep 8, 2023

This updates BasicObject—mostly to use implicit types—and also adds modernized unit tests.

More specifically,

  • BasicObject#__send__: Now accepts interned for method name, **untyped positional arguments, and an optional ?{ (*untyped, **untyped) -> untyped } block.
  • BasicObject#equal? has been made an alias of BasicObject#==
  • BasicObject#instance_eval Now accepts (string, ?string, ?int) instead of (String, ?Strig, ?Integer)
  • BasicObject#initialize returns nil instead of void
  • BasicObject#singleton_method_added: Gave a name to the Symbol parameter, now returns nil instead of void.
  • BasicObject#singleton_method_removed: Gave a name to the Symbol parameter, now returns nil instead of void.
  • BasicObject#singleton_method_undefined: Gave a name to the Symbol parameter, now returns nil instead of void.

@sampersand sampersand force-pushed the swesterman/23-09-08/basicobject branch from 6e87c0f to d330dc1 Compare September 8, 2023 18:10
@sampersand sampersand marked this pull request as ready for review September 8, 2023 18:11
@sampersand sampersand force-pushed the swesterman/23-09-08/basicobject branch from d330dc1 to 1a67453 Compare September 8, 2023 18:15
@sampersand sampersand changed the title Updated the basic object type Updated BasicObject Sep 8, 2023
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.3 milestone Sep 15, 2023
@soutaro soutaro added this pull request to the merge queue Sep 15, 2023
Merged via the queue into ruby:master with commit f201285 Sep 15, 2023
@soutaro soutaro added the Released PRs already included in the released version label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants