add Kernel#respond_to_missing?
#1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadoxV5
commented
Sep 17, 2023
test/stdlib/Kernel_test.rb
Outdated
Comment on lines
897
to
898
| "(Symbol, bool) -> bool", | ||
| obj, :respond_to_missing?, :to_s, true |
There was a problem hiding this comment.
I see other (bool) tests simply use bool for the type and true for the arg, instead of separate tests for true and false. I suppose I’ll match.
soutaro
force-pushed
the
Kernel_i_respond_to_missing
branch
from
7dab7f4 to
3502ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rbs/test/test_helper.rb
Lines 112 to 113 in fce99b9
My current project overrides
respond_to_missing?and fails Steep on the courtesysupercalls.This originally based on #1504 because they conflict (this’d be
Object#respond_to_missing?otherwise). Since the prerequisite is now (forced-pushed and) merged, this PR now bases onmasteritself.