Updated constants #1531
Merged
Updated constants #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
approved these changes
Sep 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates the toplevel constants type definitions, and introduces
constants_test.rbsto add tests.More specifically, the following changes were made:
::on all constant names was removedCROSS_COMPILINGis nowtrue?.RUBY_REVISIONis now aString.There were some difficulties with writing tests, though:
DATAwhen usingrake, asDATAis only defined if the entrypoint file has an__END__. I added__END__to the end ofconstants_test.rbsthough, so if you manually run the file it should work.CROSS_COMPILING's variations: You'd have to recompile ruby and check.