core: Kernel.fail is able to accept keyword arguments #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility, Kernel.fail (as kwnon as raise) is able to accept keyword arguments. It's not undocumented in the Ruby language documentation, but it's surely mentioned in the Ruby's spec. refs: https://github.com/ruby/ruby/blob/v3_2_0/spec/ruby/shared/kernel/raise.rb#L38-L50
soutaro
reviewed
Oct 16, 2023
| @@ -844,6 +844,7 @@ module Kernel : BasicObject | |||
| def self?.fail: () -> bot | |||
| | (string message, ?cause: Exception?) -> bot | |||
| | (_Exception exception, ?_ToS? message, ?String | Array[String] | nil backtrace, ?cause: Exception?) -> bot | |||
| | (_Exception exception, ?cause: Exception?, **untyped) -> bot | |||
There was a problem hiding this comment.
| (_Exception exception, ?String | Array[String] | nil backtrace, ?cause: Exception?, **untyped) -> bot🗑️ Withdraw this suggestion.
There was a problem hiding this comment.
Note: Kernel.raise accepts keyword arguments only if no positional arguments. So it's not good to add backtrace argument here.
irb(main):007> raise Exception, foo: 1
(irb):7:in `<main>': {:foo=>1} (Exception)
from /Users/tkomiya/.dotfiles/_rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/irb-1.8.1/exe/irb:9:in `<top (required)>'
from /Users/tkomiya/.rbenv/versions/3.2.2/bin/irb:25:in `load'
from /Users/tkomiya/.rbenv/versions/3.2.2/bin/irb:25:in `<main>'
irb(main):008> raise Exception, '', foo: 1
(irb):8:in `set_backtrace': backtrace must be Array of String (TypeError)
from (irb):8:in `raise'
from (irb):8:in `<main>'
from /Users/tkomiya/.dotfiles/_rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/irb-1.8.1/exe/irb:9:in `<top (required)>'
from /Users/tkomiya/.rbenv/versions/3.2.2/bin/irb:25:in `load'
from /Users/tkomiya/.rbenv/versions/3.2.2/bin/irb:25:in `<main>'
irb(main):009> raise Exception, '', [], foo: 1
(irb):9:in `raise': wrong number of arguments (given 4, expected 0..3) (ArgumentError)
from (irb):9:in `<main>'
from /Users/tkomiya/.dotfiles/_rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/irb-1.8.1/exe/irb:9:in `<top (required)>'
from /Users/tkomiya/.rbenv/versions/3.2.2/bin/irb:25:in `load'
from /Users/tkomiya/.rbenv/versions/3.2.2/bin/irb:25:in `<main>'
irb(main):010> raise Exception, [], foo: 1
(irb):10:in `set_backtrace': backtrace must be Array of String (TypeError)
from (irb):10:in `raise'
from (irb):10:in `<main>'
from /Users/tkomiya/.dotfiles/_rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/irb-1.8.1/exe/irb:9:in `<top (required)>'
from /Users/tkomiya/.rbenv/versions/3.2.2/bin/irb:25:in `load'
from /Users/tkomiya/.rbenv/versions/3.2.2/bin/irb:25:in `<main>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility, Kernel.fail (as kwnon as raise) is able to accept keyword arguments. It's not undocumented in the Ruby language documentation, but it's surely mentioned in the Ruby's spec.
refs: https://github.com/ruby/ruby/blob/v3_2_0/spec/ruby/shared/kernel/raise.rb#L38-L50