stdlib: Update signature of CSV.read #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It takes an IO object as `path` argument * It returns CSV::Table object when headers option given refs: * https://docs.ruby-lang.org/en/3.3/CSV.html#method-c-read * https://docs.ruby-lang.org/en/3.3/CSV.html#class-CSV-label-Option+headers
tk0miya
commented
Sep 11, 2024
| @@ -2031,7 +2031,8 @@ class CSV < Object | |||
| # File.write(path, string) | |||
| # CSV.read(path, headers: true) # => #<CSV::Table mode:col_or_row row_count:4> | |||
| # | |||
| def self.read: (String path, ?::Hash[Symbol, untyped] options) -> ::Array[::Array[String?]] | |||
| def self.read: (String | IO path, headers: true | :first_row | Array[untyped] | String, **untyped options) -> ::CSV::Table[CSV::Row] | |||
There was a problem hiding this comment.
I'm not sure what is the best to type args for CSV::Table. Please let me know if there is a more appropriated one.
There was a problem hiding this comment.
Looks like the type parameter is not used...
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
stdlib: Update signature of CSV.read
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathargumentrefs: