Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constant resolution #288

Merged
merged 1 commit into from
May 20, 2020
Merged

Fix constant resolution #288

merged 1 commit into from
May 20, 2020

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented May 20, 2020

I'm improving constant resolution in RBS to make it more Ruby compatible for the following case:

class A; end
class A::B; end
class A::B::String; end

class A
  pp String       # This is ::String
end

class A::B
  pp String       # This is A::B::String
end

So the constant name resolution should take account of every outer class/module declarations.

@soutaro soutaro force-pushed the fix-constant-resolution branch from 0da69ee to 6388f5a Compare May 20, 2020 14:38
@soutaro soutaro merged commit 6e29eb0 into master May 20, 2020
@soutaro soutaro deleted the fix-constant-resolution branch May 20, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant