Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signatures for Gem module in rubygems gem #605

Merged
merged 2 commits into from
Feb 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
run: |
apt-get update
apt-get install -y libdb-dev
- name: Install bundler
- name: Update rubygems & bundler
run: |
ruby -v
gem install bundler
gem update --system
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] The test for Gem.plugindir fails with Ruby 2.7 because Ruby 2.7 includes RubyGems 3.1 by default.

Error: test_plugindir(GemSingletonTest): NoMethodError: undefined method `plugindir' for Gem:Module

https://github.com/ruby/rbs/pull/605/checks?check_run_id=1937717810#step:8:1248

.plugindir has been available since RubyGems 3.2 (see rubygems/rubygems#3163)

So, I've updated this CI configuration to use the latest RubyGems.
This way may be correct, but it seems to me that this CI update should be done on another PR.

Can you provide me feedback, please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing the latest rubygems looks reasonable. 👍

- name: bundle config set with
run: |
echo "NO_MINITEST=true" >> $GITHUB_ENV
Expand Down
3 changes: 3 additions & 0 deletions stdlib/rubygems/0/basic_specification.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class Gem::BasicSpecification
# TODO: Add sinatures...
end
3 changes: 3 additions & 0 deletions stdlib/rubygems/0/config_file.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class Gem::ConfigFile
# TODO: Add sinatures...
end
5 changes: 5 additions & 0 deletions stdlib/rubygems/0/dependency_installer.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class Gem::DependencyInstaller
type options = Hash[Symbol, untyped] # TODO: Add options...

# TODO: Add sinatures...
end
3 changes: 3 additions & 0 deletions stdlib/rubygems/0/installer.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class Gem::Installer
# TODO: Add sinatures...
end
3 changes: 3 additions & 0 deletions stdlib/rubygems/0/path_support.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class Gem::PathSupport
# TODO: Add sinatures...
end
3 changes: 3 additions & 0 deletions stdlib/rubygems/0/platform.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class Gem::Platform
# TODO: Add sinatures...
end
7 changes: 7 additions & 0 deletions stdlib/rubygems/0/request_set.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Gem::RequestSet
# TODO: Add sinatures...
end

class Gem::RequestSet::GemDependencyAPI
# TODO: Add sinatures...
end
3 changes: 3 additions & 0 deletions stdlib/rubygems/0/requirement.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class Gem::Requirement
# TODO: Add sinatures...
end
Loading