Handle Mutex#sleep change planned in Ruby 3.1 #683
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutex#sleep in Ruby 3.1 will return nil if not interrupted. This change is needed so that ruby/ruby PR 4256 can be merged, in order to fix Ruby bug 16608.
|
CI failure does not look related to the change, as it occurs while installing dependencies, before the tests are run: |
soutaro
reviewed
Jun 18, 2021
test/stdlib/Mutex_m_test.rb
Outdated
| @@ -47,9 +47,10 @@ def test_mu_unlock | |||
| def test_sleep | |||
| mu = mu() | |||
| mu.lock | |||
| assert_send_type "(Integer) -> Integer", | |||
| return_type = "Integer#{'?' if RUBY_VERSION >= '3.1'}" | |||
| assert_send_type "(Integer) -> #{return_type}", | |||
There was a problem hiding this comment.
I think simply changing to Integer? for all versions is good.
|
Thank you @jeremyevans! |
|
@soutaro Thank you for your review. I've pushed commits to address both of those issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutex#sleep in Ruby 3.1 will return nil if not interrupted. This
change is needed so that ruby/ruby PR 4256 can be merged, in order
to fix Ruby bug 16608.