-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resolv] Add RBS file for Resolv #697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the name resolution errors like dns_name
, Sender
, etc... Write the type names in qualified style or declare classes/modules in nested style.
I also found socket classes are undefined. I think writing socket RBS is too much for this, so just adding empty classes in a file like resolv/0/sockets.rbs
is good.
@soutaro it's ready for review.
I didn't understand this comment. Can you elaborate? |
@HoneyryderChuck Could you remove the trailing whit spaces? |
@soutaro done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Added RBS signatures for the
resolv
package, + some tests.