Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed signature of caller #705

Merged
merged 1 commit into from
Jul 11, 2021
Merged

fixed signature of caller #705

merged 1 commit into from
Jul 11, 2021

Conversation

HoneyryderChuck
Copy link
Contributor

Kernel.caller signatures were overriding the case of no arguments, leading to the steep errors when performing ex.set_backtrace(caller)

@pocke
Copy link
Member

pocke commented Jul 10, 2021

How about removing ? of ?::Range[Integer] start_or_range)? Kernel.caller actually allows calling with a Range but your change disallows it.

@HoneyryderChuck
Copy link
Contributor Author

@pocke well spotted! fixed.

pocke
pocke approved these changes Jul 11, 2021
View reviewed changes
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@pocke pocke merged commit f653b55 into ruby:master Jul 11, 2021
@HoneyryderChuck HoneyryderChuck deleted the fix-caller branch July 11, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HoneyryderChuck @pocke