Fix parser to accept alias names starting with _
#723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
Fix_parser_to_accept_alias_names_starting_with____
branch
from
50bb033 to
5e4dceb
Compare
pocke
commented
Jul 22, 2021
Comment on lines
+1780
to
+1786
| def test_underscore_qualified_name | ||
| assert_raises RBS::Parser::SyntaxError do | ||
| Parser.parse_signature(<<-RBS) | ||
| type x = Foo::_bar | ||
| RBS | ||
| end | ||
| end |
There was a problem hiding this comment.
This PR doesn't affect qualified_name, but I added the test for qualifed_name to clear that it doesn't accept tUNDERSCOREIDENT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #722
I've confirmed other
tINTERFACEIDENTusage, forvar_name_opt,simple_name, andinterface_nameare valid.var_name_opthas been fixed by #721.simple_nameis used byqualified_name, and it doesn't need to accept underscored name. For example,Foo::_baris invalid always.inteface_nameis justtINTERFACEIDENT, so it doesn't need to accepttUNDERSCOREIDENT.Now
exe/rbs parse ../gem_rbs_collection/gems/**/*.rbsprints no error 🎉