Fix unexpected CollectionNotAvailable without gems from git source
#795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
changed the title
git sourcegit source
pocke
force-pushed
the
Fix_unexpected_CollectionNotAvailable_without_gems_from__git__source
branch
from
87d21d1 to
34adcf5
Compare
pocke
changed the title
git sourcegit source
pocke
deleted the
Fix_unexpected_CollectionNotAvailable_without_gems_from__git__source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the unexpected CollectionNotAvailable error when the lockfile only has non-
gitsource gems.Currently the collection installer makes
.gem_rbs_collectiondirectory ifgitsource gems exist. AndConfig#check_rbs_availability!method checks the directory existence. Then the error is raised.This patch makes sure that the directory is created by
rbs collection installeven ifgitsource gem does not exist.