Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URI signatures #846

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Fix URI signatures #846

merged 3 commits into from
Dec 21, 2021

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Dec 17, 2021

Fix #845

I fixed the definitions of URI.parse and URI.for.
And I also added the missing subclasses.

CRuby allows users to add classes later using URI.register_scheme, but users can override URI.parse and URI.for.

soutaro
soutaro approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@soutaro soutaro merged commit 74591f7 into ruby:master Dec 21, 2021
@ksss ksss deleted the uri-parse-for branch December 22, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing URI::for and incorrect URI::parse return type
2 participants
@ksss @soutaro