Add manifest.yaml for rbs gem #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously loading rbs gem's RBSs raises an error, which displays "no Logger found", without specifying the all dependencies in the rbs_collection.yaml. Because I forgot adding manifest.yaml for this gem. This patch adds manifest.yaml for RBS gem to fix this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ruby/typeprof#111
Previously loading rbs gem's RBSs raises an error, which displays "no
Logger found", without specifying the all dependencies in the
rbs_collection.yaml.
Because I forgot adding manifest.yaml for this gem.
This patch adds manifest.yaml for RBS gem to fix this problem.
By the way, the dependencies list is duplicated with Steepfile. I should remove the duplication by introducing
rbs collectionfor this repository, but I remained the duplication to keep this PR simple. I'll do it soon.