[rbs collection] Fix error message to tell gem name when source is not found #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahashim
changed the title
|
Thanks for this and many PRs on ruby/gem_rbs_collection repo! I'll lock at the PRs after a while. I'm busy this week so it will be delayed. I'll review PRs next weekend at least. Please wait a moment 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current
rbs collectioncommand, if the rbs of gem listed inrbs_collection.yamlwas not found, the error message did not tell which gem was missing.This PR modifies the error message to put the name of the missing gem in the error message.