Add DidYouMean #980
Merged
Add DidYouMean #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
reviewed
May 8, 2022
| # - new(dictionary:, separator: '/', augment: nil) | ||
| # --> | ||
| # | ||
| def initialize: (dictionary: Array[String], ?separator: String, ?augment: bool?) -> void |
There was a problem hiding this comment.
[Goodcheck] Prefer
boolishoverboolfor method arguments and block return values (view)See the doc below:
https://github.com/ruby/rbs/blob/78d04a2db0f1c4925d2b13c2939868edf9465d6c/docs/syntax.md#bool-or-boolish
Rule rbs.prefer_boolishYou can close this issue if no need to fix it. Learn more.
I closed this issue. Reason:
- When you strictly want
true | false. Useboolin this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote the type for DidYouMean.
DidYouMean is mostly for internal use.
However,
DidYouMean::Correctableis also used in Rails, so I think type definition is necessary.